Skip to content

Comments

Add noise-machine-ability community ability#111

Merged
Rizwan-095 merged 5 commits intoopenhome-dev:devfrom
yonaseth12:noise-machine-ability-yonas
Feb 24, 2026
Merged

Add noise-machine-ability community ability#111
Rizwan-095 merged 5 commits intoopenhome-dev:devfrom
yonaseth12:noise-machine-ability-yonas

Conversation

@yonaseth12
Copy link
Contributor

What does this Ability do?

Plays relaxing ambient sounds (rain, ocean waves, cafe, white noise, etc.) for a user-selected duration. Users can stop playback anytime by saying “stop” (or other exit words), and the Ability exits cleanly back to normal OpenHome flow.

Suggested Trigger Words

  • "noise machine"
  • "sound machine"
  • "sleep sounds"
  • "play rain"
  • "ocean waves"
  • "white noise"
  • "cafe sounds"
  • "forest birds"

Type

  • New community Ability
  • Improvement to existing Ability
  • Bug fix
  • Documentation update

External APIs

  • No external APIs
  • Uses external API(s):

Testing

  • Tested in OpenHome Live Editor
  • All exit paths tested (said "stop", "exit", etc.)
  • Error scenarios tested (bad input, unrecognized sound name, invalid duration, missing audio file)

Checklist

  • Files are in community/noise-machine/
  • main.py follows SDK pattern (extends MatchingCapability, has register_capability + call)
  • README.md included with description, suggested triggers, and setup
  • resume_normal_flow() called on every exit path
  • No print() — using editor_logging_handler
  • No hardcoded API keys — using placeholders
  • No blocked imports (redis, connection_manager, user_config)
  • No asyncio.sleep() or asyncio.create_task() — using session_tasks
  • Error handling on all external calls
  • Tested in OpenHome Live Editor

Anything else?

  • Ensure the 15 MP3 files are uploaded into the Ability workspace with the exact filenames referenced in main.py (e.g., cafe.mp3, ocean_waves.mp3, white_noise.mp3, etc.).
  • Recommended quick demo flow: trigger → pick sound (“cafe”) → set duration (“one hour”) → stop (“stop”).

@yonaseth12 yonaseth12 requested a review from a team as a code owner February 21, 2026 23:20
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2026

🔀 Branch Merge Check

PR direction: noise-machine-ability-yonasdev

Passednoise-machine-ability-yonasdev is a valid merge direction

@github-actions github-actions bot added first-contribution First-time contributor community-ability Community-contributed ability labels Feb 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2026

✅ Ability Validation Passed

📋 Validating: community/noise-machine
  ✅ All checks passed!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2026

🔍 Lint Results

__init__.py — Empty as expected

Files linted: community/noise-machine/main.py

✅ Flake8 — Passed

✅ All checks passed!

@codermohsin
Copy link
Contributor

Your ability submission is currently under review.

Our team will carefully evaluate it and provide feedback shortly.

Thank you for your submission

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

✅ Community PR Path Check — Passed

All changed files are inside the community/ folder. Looks good!

@abubakar4360
Copy link
Contributor

The core functionality of the ability works as expected. However, when specifying a duration of ‘1 minute’ for playing rain sounds, the timer does not update and defaults to 5 minutes. The custom duration parameter is not being respected and should be corrected.

@yonaseth12
Copy link
Contributor Author

The core functionality of the ability works as expected. However, when specifying a duration of ‘1 minute’ for playing rain sounds, the timer does not update and defaults to 5 minutes. The custom duration parameter is not being respected and should be corrected.

The requirement specified by Chris limits the minimum to 5 mins

@abubakar4360 abubakar4360 reopened this Feb 24, 2026
Copy link
Contributor

@abubakar4360 abubakar4360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the community.
We will proceed with adopting this ability for a 30-day evaluation period to monitor performance, identify any bugs, and implement any necessary fixes or optimizations. If the ability proves stable and meets our quality standards during this period, we will move forward with publishing it to the marketplace, ensuring full credit is given to the original author for their work and contribution.
We truly appreciate your effort and encourage you to continue developing and submitting new abilities. Contributions like yours help strengthen the ecosystem, and we look forward to seeing more of your work.

@Rizwan-095 Rizwan-095 merged commit 7138cda into openhome-dev:dev Feb 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-ability Community-contributed ability first-contribution First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants